CI: Use uv package and project manager on GHA and RTD
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
uv package and project manageruv package and project manager on GHA and RTD
surister
approved these changes
Jan 25, 2025
amotl
commented
Jan 25, 2025
docs/requirements.txt
Outdated
Comment on lines
1
to
7
| # Install the local crate-docs-theme package by specifying parent directory, | ||
| # because `pip` is run from there. | ||
| --editable=. | ||
| # Install the `crate-docs-theme` package from the local working tree | ||
| # in editable mode. `pip` is invoked from the root directory. | ||
| # | ||
| # When using `uv`, don't use `--editable=.`. | ||
| # https://github.com/astral-sh/uv/issues/10941 | ||
|
|
||
| -e . |
There was a problem hiding this comment.
This has been fixed/improved swiftly by @charliermarsh, thank you!
- Understand
--editable=.also inrequirements.txtastral-sh/uv#10941 - Allow optional
=for editables inrequirements.txtastral-sh/uv#10954
Let's wait for a new release of uv, then revert this change again. It does not make sense to merge it this way with a misleading indication that something would not be right. Given the current high release cadence, it will probably not be far away.
There was a problem hiding this comment.
Using --editable=. works well now, thank you Charlie!
kneth
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Add the
uvprogram to the toolbox, in this case to speed up documentation rebuilds, both on GHA and RTD.Details
uvis very versatile, and provides better support to work with virtualenvs in different situations, unique support for one-off scripts with inline dependencies, and much more.References
--editable=.also inrequirements.txtastral-sh/uv#10941