Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB CDC: Fix MODIFY operation by propagating NewImage fully #60

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Sep 25, 2024

Problem

Hey guys, I noticed earlier that DynamoDB updates that removed fields from items were not synced properly to CrateDB, would you know why?

Evaluation

When breaking down CDC MODIFY statements into individual SET clauses, deleted attributes would not be propagated correctly.

Solution

Don't break down into SET clauses, but insert data from NewImage as-is.

@hammerhead, @surister: Please review retroactively. Thank you!

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
@amotl amotl marked this pull request as ready for review September 25, 2024 22:53
@amotl amotl merged commit 7799ee7 into main Sep 25, 2024
23 checks passed
@amotl amotl deleted the dynamodb-fix-modify branch September 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant