Add "RegressError" to the "regress" module #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By exposing the exception as a module attribute, we ensure that callers can use that name in `except` clauses. Without this addition, `regress.RegressError` can still be raised, but it has a type which can't be referred to by name. pyo3 docs use `PyModule.add(...)` in a formulation similar to, but slightly different from, `add_class` usage.
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By exposing the exception as a module attribute, we ensure that callers can use that name in
exceptclauses.Without this addition,
regress.RegressErrorcan still be raised, but it has a type which can't be referred to by name.pyo3 docs use
PyModule.add(...)in a formulation similar to, but slightly different from,add_classusage.I noticed this when trying to setup
regressto replace the"format": "regex"checker incheck-jsonschema. I'll be fine usingexcept Exceptionfor now, but it would be nice to be able to write the exception handler asexcept regress.RegressError.