Update Daikin2's Cool mode min temp to 18C #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markszabo
approved these changes
Apr 1, 2019
|
I suspect this limitation is on the cooling modes only. I’ll verify this when I finish getting my OpenHAB cooling control rules working |
Per: #658 (comment) @sheppy99 believes this different min temp is only in cool mode. Adjust and add tests for this. Ref #644
|
@markszabo Can you Please Take Another Look? (PTAL) as I've changed it a fair bit with the last commit due to @sheppy99 's feedback. |
crankyoldgit
changed the title
|
Still LGTM :) |
crankyoldgit
added a commit
that referenced
this pull request
Apr 30, 2019
_v2.6.0 (20190430)_ **[Bug Fixes]** - Fixed problem where LG protocol used wrong duty cycle for repeat. (#687) - Fix checksum calculation for Daikin protocols. (#678) - Fix the byte array version of sendGree() (#684, #685) - Fix artificial vs. real state creation on HaierAC. (#668, #671) - Fix issues caused by having `MQTT_ENABLE` set to false. (#677) - Fix compile problem when DEBUG is defined. (#673, #674) - Fix Minor bug with MQTT_ENABLE False condition (#654) **[Features]** - Experimental support for DAIKIN216 (ARC433B69) (#690) - Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667) - Support more features of TCL A/C (#656) - Add LEGO(TM) Power Functions IR protocol. (#655) - Add Panasonic AC RKR model & Example (#649) - DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678) **WARNING**: Previous `sendDaikin()` calls may not work. Please recapture codes or use `kDaikinStateLengthShort` for `nbytes` in those calls. - IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680) **WARNING**: Previous users may need to fully wipe/reset the SPIFFS/WifiManager settings by visiting `http://<your_esp8266's_ip_address>/reset` prior to or after update. - Add Wifi filtering options to IRMQTTServer. (#679) - Add advanced aircon/climate functionality to IRMQTTServer (#677) - Initial prototype of a common interface for all A/Cs. (#664) - Improve MQTT topic usage for feedback messages. (#663) - Add multiple independent GPIO sending support via MQTT. (#661) **[Misc]** - Adjust kGreeHdrSpace to 4500 (#684, #686) - Add Home Assistant mqtt climate instructions. (#682) - Implement htmlEscape() to prevent XSS etc. (#681) - Add F() Macros (#670) - Update Daikin2's Cool mode min temp to 18C (#658) - Change per byte bit-order in Electra protocol. (#648) - Improve Daikin2 power on/off. (#647)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Apr 30, 2019
_v2.6.0 (20190430)_ **[Bug Fixes]** - Fixed problem where LG protocol used wrong duty cycle for repeat. (#687) - Fix checksum calculation for Daikin protocols. (#678) - Fix the byte array version of sendGree() (#684, #685) - Fix artificial vs. real state creation on HaierAC. (#668, #671) - Fix issues caused by having `MQTT_ENABLE` set to false. (#677) - Fix compile problem when DEBUG is defined. (#673, #674) - Fix Minor bug with MQTT_ENABLE False condition (#654) **[Features]** - Experimental support for DAIKIN216 (ARC433B69) (#690) - Experimental support for Mitsubishi Heavy Industries A/Cs. (#660, #665, #667) - Support more features of TCL A/C (#656) - Add LEGO(TM) Power Functions IR protocol. (#655) - Add Panasonic AC RKR model & Example (#649) - DAIKIN/IRDaikinESP overhaul and add Comfort mode support. (#678) **WARNING**: Previous `sendDaikin()` calls may not work. Please recapture codes or use `kDaikinStateLengthShort` for `nbytes` in those calls. - IRMQTTServer: Move MQTT server and other parameters to WifiManager. (#680) **WARNING**: Previous users may need to fully wipe/reset the SPIFFS/WifiManager settings by visiting `http://<your_esp8266's_ip_address>/reset` prior to or after update. - Add Wifi filtering options to IRMQTTServer. (#679) - Add advanced aircon/climate functionality to IRMQTTServer (#677) - Initial prototype of a common interface for all A/Cs. (#664) - Improve MQTT topic usage for feedback messages. (#663) - Add multiple independent GPIO sending support via MQTT. (#661) **[Misc]** - Adjust kGreeHdrSpace to 4500 (#684, #686) - Add Home Assistant mqtt climate instructions. (#682) - Implement htmlEscape() to prevent XSS etc. (#681) - Add F() Macros (#670) - Update Daikin2's Cool mode min temp to 18C (#658) - Change per byte bit-order in Electra protocol. (#648) - Improve Daikin2 power on/off. (#647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sheppy99 has found that the daikin2 A/Cs have a min temp of 18C.
Add unit test coverage for IRDaikin2's
set/getTemp()Ref: #644