Add deep support for the Hitachi 28-Byte A/C Protocol #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Limit fan speed when in certain modes. * More unit test coverage.
|
Reached the 7 day review limit without any negative comments. Merging. |
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing '}' in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 23, 2018
**[Features]** - Add deep support for the Hitachi 28-Byte A/C Protocol (#563) - Deep decoding for Whirlpool A/C (#572) - Improve security options for IRMQTTServer example. (#575) - Require a changed firmware password before upload. (#576) **[Misc]** - Add missing `}` in output of Auto analyse. (#562) - Make A/C example code a bit more simple. (#571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental IRHitachiAc class.
Note: We incorrectly (historically) have Hitachi as MSB First bit ordering, it's really in LSBF order.
Due to legacy usage, we'll keep the sending routines and array data in MSBF and reverse bits as needed.
Fixes #417
Fixes #453