Create sk-SK.h #2091
Merged
Create sk-SK.h #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonhuisman
suggested changes
Apr 28, 2024
src/locale/sk-SK.h
Outdated
Comment on lines
4
to
5
| #ifndef LOCALE_SK-SK_H_ | ||
| #define LOCALE_SK-SK_H_ |
There was a problem hiding this comment.
As the build failure says, that dash - should be an underscore _...
There was a problem hiding this comment.
Yep.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
src/locale/sk-SK.h
Outdated
| "Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \ | ||
| "Upraviť a zväčšiť `kCaptureBufferSize`." | ||
|
|
||
| #endif // LOCALE_SK-SK_H_ |
There was a problem hiding this comment.
Same error as at the top...
There was a problem hiding this comment.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
crankyoldgit
requested changes
Apr 28, 2024
src/locale/sk-SK.h
Outdated
| "Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \ | ||
| "Upraviť a zväčšiť `kCaptureBufferSize`." | ||
|
|
||
| #endif // LOCALE_SK-SK_H_ |
There was a problem hiding this comment.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
src/locale/sk-SK.h
Outdated
Comment on lines
17
to
18
| #define D_STR_TURBO "Turbo" | ||
| #define D_STR_SUPER "Super" |
There was a problem hiding this comment.
When they are the same as the default, please don't include them.
i.e. You should be able to remove these two lines.
| #define D_STR_LIGHT "Svetlo" | ||
| #define D_STR_POWERFUL "Výkonný" | ||
| #define D_STR_QUIET "Tichý" | ||
| #define D_STR_ECONO "Econo" |
| #define D_STR_FILTER "Filter" | ||
| #define D_STR_3D "3D" | ||
| #define D_STR_CELSIUS "Celzia" | ||
| #define D_STR_FAHRENHEIT "Fahrenheit" |
src/locale/sk-SK.h
Outdated
Comment on lines
65
to
66
| #define D_STR_START "Štart" | ||
| #define D_STR_STOP "Stop" |
There was a problem hiding this comment.
Oops. Yeah, just remove Stop
src/locale/sk-SK.h
Outdated
| #define D_STR_DISPLAY "Displej" | ||
| #define D_STR_WEEKLY "Týždenne" | ||
| #define D_STR_WEEKLYTIMER D_STR_WEEKLY " " D_STR_TIMER // Needs `D_STR_WEEKLY`! | ||
| #define D_STR_WIFI "WiFi" |
src/locale/sk-SK.h
Outdated
Comment on lines
123
to
126
| #define D_STR_MAX "Max" | ||
| #define D_STR_MAXIMUM "Maximum" | ||
| #define D_STR_MIN "Min" | ||
| #define D_STR_MINIMUM "Minimum" |
src/locale/sk-SK.h
Outdated
Comment on lines
197
to
198
| #define D_STR_TRUE "True" | ||
| #define D_STR_FALSE "False" |
src/locale/sk-SK.h
Outdated
Comment on lines
202
to
226
|
|
||
| // Model Names | ||
| #define D_STR_YAW1F "YAW1F" | ||
| #define D_STR_YBOFB "YBOFB" | ||
| #define D_STR_YX1FSF "YX1FSF" | ||
| #define D_STR_V9014557_A "V9014557-A" | ||
| #define D_STR_V9014557_B "V9014557-B" | ||
| #define D_STR_RLT0541HTA_A "R-LT0541-HTA-A" | ||
| #define D_STR_RLT0541HTA_B "R-LT0541-HTA-B" | ||
| #define D_STR_ARRAH2E "ARRAH2E" | ||
| #define D_STR_ARDB1 "ARDB1" | ||
| #define D_STR_ARREB1E "ARREB1E" | ||
| #define D_STR_ARJW2 "ARJW2" | ||
| #define D_STR_ARRY4 "ARRY4" | ||
| #define D_STR_ARREW4E "ARREW4E" | ||
| #define D_STR_GE6711AR2853M "GE6711AR2853M" | ||
| #define D_STR_AKB75215403 "AKB75215403" | ||
| #define D_STR_AKB74955603 "AKB74955603" | ||
| #define D_STR_AKB73757604 "AKB73757604" | ||
| #define D_STR_LG6711A20083V "LG6711A20083V" | ||
| #define D_STR_KKG9AC1 "KKG9AC1" | ||
| #define D_STR_KKG29AC1 "KKG29AC1" | ||
| #define D_STR_LKE "LKE" | ||
| #define D_STR_NKE "NKE" | ||
| #define D_STR_DKE "DKE" |
There was a problem hiding this comment.
You should be able to remove all the model & protocol names.
Review feedback corrections.
crankyoldgit
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slovak language