SilverCrest Fan example #1606
Closed
SilverCrest Fan example #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karol-brejna-i
force-pushed
the
silvercrest-fan
branch
from
41ba835 to
0843218
Compare
karol-brejna-i
force-pushed
the
silvercrest-fan
branch
from
0843218 to
0f2036f
Compare
karol-brejna-i
changed the title
|
We already have many examples of how to use the library, adding example s for every device the library supports will not scale. But maybe we should consider adding a separate repo with only examples instead? |
|
Correct. We will happily link to your repo/example. But we don't need/want more example code to maintain and test/compile each and every time we make a minor change to the library. It all adds up and takes a lot of time each build. |
|
I totally get the point. Let's close this PR. I'll prepare a dedicated repo with the example (more description, etc.) and issue a dedicated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1603, the library supports Misting Pedestal Fan / SilverCrest SSVS 85 A1 Fan.
This PR introduces a simple example of how to send proper commands to the fan.
Consider including it the source base.