Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coolix protocol "fan only mode" sends "dry mode" command instead #2103

Closed
mdk2412 opened this issue Jun 5, 2024 · 1 comment · Fixed by #2104
Closed

Coolix protocol "fan only mode" sends "dry mode" command instead #2103

mdk2412 opened this issue Jun 5, 2024 · 1 comment · Fixed by #2104
Assignees
Labels

Comments

@mdk2412
Copy link

mdk2412 commented Jun 5, 2024

Version/revision of the library used

Version of tasmota 13.4.0.

Describe the bug

Sending a command to switch to "fan only mode" on an air conditioning "Remko ML 265 DC" using the coolix protocol results in sending a "dry mode" command instead: IRHVAC {"Vendor":"COOLIX","Mode":"Fan","Power":"On","FanSpeed":"Auto"} results in {"IrReceived":{"Protocol":"COOLIX","Bits":24,"Data":"0xB21FC4","DataLSB":"0x4DF823","Repeat":0,"IRHVAC":{"Vendor":"COOLIX","Model":-1,"Command":"Control","Mode":"Dry","Power":"On","Celsius":"On","Temp":25,"FanSpeed":"Auto","SwingV":"Off","SwingH":"Off","Quiet":"Off","Turbo":"Off","Econo":"Off","Light":"Off","Filter":"Off","Clean":"Off","Beep":"Off","Sleep":-1,"iFeel":"Off","SensorTemp":null}}}. Correct command would be (see ir_coolix.h line 93) : irsend {"Protocol":"COOLIX","Bits":24,"Data":"0xB2BFE4","DataLSB":"0x4DFD27","Repeat":0}

This is not a bug in itself as the library is apparently designed to do so, see ir_coolix.cpp lines 382-388, according to which "fan mode" is changed to "dry mode" instead. However, thus the A/C does not start "fan only" mode but "dry" mode instead.

@NiKiZe

This comment was marked as outdated.

crankyoldgit added a commit that referenced this issue Jun 6, 2024
Mode was being incorrectly set in produced message as a "Dry" command.
Adjusting order of when setMode() was called fixes the issue.
Add a Unit test to confirm it is fixed and catch this in future.

Fixes #2103
@crankyoldgit crankyoldgit self-assigned this Jun 6, 2024
crankyoldgit added a commit that referenced this issue Jun 6, 2024
Mode was being incorrectly set in produced message as a "Dry" command.
Adjusting order of when setMode() was called fixes the issue.
Add a Unit test to confirm it is fixed and catch this in future.

Fixes #2103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants