Don't import where() from ape
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is a read only mirror of CRAN, please see the package authors in the |
|
Thank you @DavisVaughan, please make a PR on the develop branch here https://github.com/mpallocc/auto-go and we'll integrate it in our next release :) |
|
@fabio-t it is helpful for us if you include a BugReports URL like this https://github.com/r-lib/vctrs/blob/af3fcc486664e30b588df1296a212e583ef00d18/DESCRIPTION#L28 We can automatically detect that and that lets us send the PR to the right place. |
|
Will do! |
|
@gaborcsardi the issues has been fixed and I've added the BugReports for the next release, you can close here if you wish 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of dplyr will export
where()and this causes a name conflict withape::where()because you import all of dplyr and all of ape. This PR fixes this by adding an exception forape::where(). You seem to actually usewhere()in a dplyr context, so this made more sense to me.We are releasing dplyr to CRAN today. Unfortunately we missed your package in our round of revdep PRs a month ago because autoGO was just released to CRAN in January.