Extracts prepare method to preparable trait

craigpaul · Oct 26, 2016 · 66deadd · 66deadd
1 parent eb01acf
commit 66deadd
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 50 deletions.
diff --git a/src/Preparable.php b/src/Preparable.php
@@ -0,0 +1,53 @@
+<?php
+
+namespace CraigPaul\Moneris;
+
+trait Preparable
+{
+    /**
+     * Prepare the receipt data.
+     *
+     * @param $data
+     *
+     * @return array
+     */
+    protected function prepare($data, array $params)
+    {
+        $array = [];
+
+        foreach ($params as $param) {
+            $key = $param['key'];
+            $property = $param['property'];
+
+            $array[$property] = isset($data->$key) && !is_null($data->$key) ? $data->$key : null;
+
+            if (isset($param['cast'])) {
+                switch ($param['cast']) {
+                    case 'boolean':
+                        $array[$property] = isset($array[$property]) ? (is_string($array[$property]) ? $array[$property] : $array[$property]->__toString()) : null;
+                        $array[$property] = isset($array[$property]) && !is_null($array[$property]) ? ($array[$property] === 'true' ? true : false) : false;
+
+                        break;
+                    case 'float':
+                        $array[$property] = isset($array[$property]) ? (is_string($array[$property]) ? floatval($array[$property]) : floatval($array[$property]->__toString())) : null;
+
+                        break;
+                    case 'string':
+                        $array[$property] = isset($array[$property]) ? (is_string($array[$property]) ? $array[$property] : $array[$property]->__toString()) : null;
+
+                        break;
+                    case 'array':
+                        $array[$property] = (array)$array[$property];
+                }
+            }
+
+            if (isset($param['callback'])) {
+                $callback = $param['callback'];
+
+                $array[$property] = $this->$callback($array[$property]);
+            }
+        }
+
+        return $array;
+    }
+}
diff --git a/src/Receipt.php b/src/Receipt.php
@@ -4,6 +4,8 @@
 
 class Receipt
 {
+    use Preparable;
+
     /**
      * @var array
      */
@@ -16,20 +18,7 @@ class Receipt
      */
     public function __construct($data)
     {
-        $this->data = $this->prepare($data);
-    }
-
-    /**
-     * Prepare the receipt data.
-     *
-     * @param $data
-     *
-     * @return array
-     */
-    protected function prepare($data)
-    {
-        $array = [];
-        $params = [
+        $this->data = $this->prepare($data, [
             ['property' => 'amount', 'key' => 'TransAmount', 'cast' => 'float'],
             ['property' => 'authorization', 'key' => 'AuthCode', 'cast' => 'string'],
             ['property' => 'avs_result', 'key' => 'AvsResultCode', 'cast' => 'string'],
@@ -47,42 +36,7 @@ protected function prepare($data)
             ['property' => 'time', 'key' => 'TransTime', 'cast' => 'string'],
             ['property' => 'transaction', 'key' => 'TransID', 'cast' => 'string'],
             ['property' => 'type', 'key' => 'TransType', 'cast' => 'string'],
-        ];
-
-        foreach ($params as $param) {
-            $key = $param['key'];
-            $property = $param['property'];
-
-            $array[$property] = isset($data->$key) && !is_null($data->$key) ? $data->$key : null;
-
-            if (isset($param['cast'])) {
-                switch ($param['cast']) {
-                    case 'boolean':
-                        $array[$property] = isset($array[$property]) ? $array[$property]->__toString() : null;
-                        $array[$property] = isset($array[$property]) && !is_null($array[$property]) ? ($array[$property] === 'true' ? true : false) : false;
-
-                        break;
-                    case 'float':
-                        $array[$property] = isset($array[$property]) ? floatval($array[$property]->__toString()) : null;
-
-                        break;
-                    case 'string':
-                        $array[$property] = isset($array[$property]) ? $array[$property]->__toString() : null;
-
-                        break;
-                    case 'array':
-                        $array[$property] = (array)$array[$property];
-                }
-            }
-
-            if (isset($param['callback'])) {
-                $callback = $param['callback'];
-
-                $array[$property] = $this->$callback($array[$property]);
-            }
-        }
-
-        return $array;
+        ]);
     }
 
     /**