Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore / demonstrate how the Gulp Starter rails helpers might work with Middleman #4

Closed
craigmdennis opened this issue Apr 5, 2016 · 6 comments
Closed

Explore / demonstrate how the Gulp Starter rails helpers might work with Middleman #4

craigmdennis opened this issue Apr 5, 2016 · 6 comments
Labels
docs enhancement

Comments

@craigmdennis
Copy link
Owner

No description provided.

@ryanlindsey
Copy link

I'm very interested in this as well. I was going to dig into this myself but would be happy to help if you're interested.

craigmdennis added a commit that referenced this issue Apr 5, 2016
@craigmdennis
Refs #4: Add rails helper files from Gulp Starter
b26f133
@craigmdennis
Copy link
Owner Author

@pixelsonly Feel free to experiment and post your findings. I've created the branch 4_asset-helpers

craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Include rails helper (with error)
db5294c 
- The helpers are incuded in Middleman, no parsing errors
- ERROR:  `no implicit conversion of Symbol into String`

`middleman-gulp-starter/helpers/gulp_asset_helper.rb: in join, line 14`
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Correctly detect environment
b2fcf13
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Change regex & fix mismatched types
77bed72 
- Remove `.tmp` form the URL
- Make sure interpreted as a string
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Turn file revving on by default
9c64f43
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Add helper usage information
e98af86
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Ignore un-revved files in Middleman
a959293 
WIP: Need to do this dynamically
@craigmdennis
Copy link
Owner Author

File revving is now working and the Rails helpers have been ported to Middleman.

Unexpected side-effect: The pre-revved files are copied to the build directory by Middleman.

Ideally we need a way to iterate through the rev-manifest.json and ignore those base files dynamically. It will get really annoying if someone has lots of files, as each file needs to be ignored manually at the moment.

@craigmdennis craigmdennis added this to the 1.2 milestone Apr 6, 2016
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Ignore original files if revving enabled
caed349 
- Loop through the manifest file's key
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Rev the logo
f0fd463
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Docs: Correctly reference helper names
b2ab526
craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Refs #4: Docs: Better code commented
555399b
@craigmdennis
Copy link
Owner Author

@pixelsonly Want to check out this branch and see it works for you?

@craigmdennis
Copy link
Owner Author

On a project with blogs I am now getting no implicit conversion of nil into String on Line 16 of the helper

@craigmdennis
Copy link
Owner Author

I'd missed off the extension. All good.

craigmdennis added a commit that referenced this issue Apr 6, 2016
@craigmdennis
Feat #4: File revving
09a6c21 
- Correctly detect environment
- Remove `.tmp` form the URL
- Make sure interpreted as a string
- Turn file revving on by default
- Add helper usage information
- Dynamically ignore un-revved files in Middleman
- Docs: Better code commented
- Bump version to v1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@craigmdennis @ryanlindsey