Add translations + prevent error when adding field #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riasvdv
commented
May 14, 2017
riasvdv
commented
- Adds translations for "Opening Time" and "Closing Time"
- Prevents an error when adding the field to a Global Section
brandonkelly
requested changes
May 14, 2017
src/templates/input.html
Outdated
| @@ -2,7 +2,7 @@ | |||
| {% from "_includes/forms" import time %} | |||
| <tr> | |||
| <th> | |||
| {{ craft.i18n.getLocaleData().getWeekDayName(day) }} | |||
| {{ craft.i18n.getLocaleData().getWeekDayName(day) | ucfirst }} | |||
There was a problem hiding this comment.
Is there a place where this was necessary? Week day names should already be correctly capitalized.
There was a problem hiding this comment.
I guess officially in Dutch they're not capitalised but I thought it looked nicer, didn't mean to add this to the PR!
src/fields/StoreHoursField.php
Outdated
| @@ -57,6 +57,10 @@ public function getInputHtml($value, ElementInterface $element = null): string | |||
| */ | |||
| public function serializeValue($value, ElementInterface $element = null) | |||
| { | |||
| if (!$value) { | |||
| return null; | |||
There was a problem hiding this comment.
Let’s move this to a separate PR. Each PR should be focussed on a single feature/enhancement/bugfix. Thanks!
There was a problem hiding this comment.
Will do! I'll update the PR tomorrow
brandonkelly
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.