Query database to retrieve mysql-version to support mariadb and other…

[benediktblank]

… distros with non-standard ports, attributes etc.

Description

We had an issue on Azure, that in certain conditions the version retrieved from PDO::ATTR_SERVER_VERSION was completely wrong, not even a mariadb version.
That PR would change the version check here to a query directly on the database to get the version.
If that fails, it would fallback to PDO::ATTR_SERVER_VERSIO

Related issues

[angrybrad]

This would get you past the server check logic, but there are other places where Craft (and the underlying framework Yii), use PDO::ATTR_SERVER_VERSION checks to determine what SQL to generate and/or logic to run.

You can search for Craft::$app->getDb()->getSchema()->getServerVersion() to see a list.

Seems like Azure has a workaround for this... if you use ports 3308 or 3309, it'll end up reporting the correct MySQL version.

https://docs.microsoft.com/en-us/azure/mysql/single-server/concepts-connect-to-a-gateway-node

[benediktblank]

This would get you past the server check logic, but there are other places where Craft (and the underlying framework Yii), use PDO::ATTR_SERVER_VERSION checks to determine what SQL to generate and/or logic to run.

You can search for Craft::$app->getDb()->getSchema()->getServerVersion() to see a list.

Seems like Azure has a workaround for this... if you use ports 3308 or 3309, it'll end up reporting the correct MySQL version.

https://docs.microsoft.com/en-us/azure/mysql/single-server/concepts-connect-to-a-gateway-node

I know this work around, but it doesn't work for MariaDB with disabled SSL.
When you run a MariaDB service and disable SSL connection it always returns a MySQL version, on every port:

bash-5.1$ php sqltest.php
Port: 3306
5.6.47.0
bash-5.1$ php sqltest.php
Port: 3308
5.7.29.0
bash-5.1$ php sqltest.php
Port: 3309
8.0.15.0

I've searched for "Craft::$app->getDb()->getSchema()->getServerVersion()" as suggested and it only came up with one result in cms/application/vendor/craftcms/cms/src/db/mysql/Schema.php inside the getDefaultBackupCommand function.

Are there more?

[angrybrad]

When you run a MariaDB service and disable SSL connection it always returns a MySQL version, on every port:

Ewww...

getSchema()->getServerVersion() would probably be a better search - I'm counting 10 instances across Craft and Yii on a fresh installation.

But even then, there's nothing stopping a plugin or custom module from doing PDO::ATTR_SERVER_VERSION and getting improper results. 🤔

[benediktblank]

When you run a MariaDB service and disable SSL connection it always returns a MySQL version, on every port:

Ewww...

Yeah, it's really bad.

getSchema()->getServerVersion() would probably be a better search - I'm counting 10 instances across Craft and Yii on a fresh installation.

But even then, there's nothing stopping a plugin or custom module from doing PDO::ATTR_SERVER_VERSION and getting improper results. 🤔

Alright. We've talked with Microsoft now directly and there apparently is a better server structure that should give us the correct version. It seems the others are kind of "legacy".

[angrybrad]

Interesting - do you happen to have a public link to what Microsoft said so we can point people that run into this in the future?

[benediktblank]

Interesting - do you happen to have a public link to what Microsoft said so we can point people that run into this in the future?

It's called "Azure Database for MySQL Flexible Server". MariaDB is currently not available for these so we will switch to MySQL now. But it's apparently more modern server structure compared to the other services.

[angrybrad]

@benediktblank thanks for that!