Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valueType() should be more than string #13

Closed
markhuot opened this issue Dec 20, 2023 · 1 comment
Closed

valueType() should be more than string #13

markhuot opened this issue Dec 20, 2023 · 1 comment

Comments

@markhuot
Copy link

html-field/src/HtmlField.php

Line 40 in 4797c9c

return 'string';

At the very least this should probably be string|null. But it would be really nice to see the HtmlFieldData|null in there…?
brandonkelly added a commit to craftcms/ckeditor that referenced this issue Oct 15, 2024
@brandonkelly
More specific phpType()
3969e3d 
Resolves craftcms/html-field#13
@brandonkelly
Copy link
Member

Just tagged v2.1.1 and 3.1.1 with that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @markhuot