Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entries in site-group sites disabled when importing to a specific site #1208

Closed
ThomasDeMarez opened this issue Dec 23, 2022 · 2 comments · Fixed by #1212
Closed

Entries in site-group sites disabled when importing to a specific site #1208

ThomasDeMarez opened this issue Dec 23, 2022 · 2 comments · Fixed by #1212
Assignees
@brianjhanson
Labels
bug

Comments

@ThomasDeMarez
Copy link
Contributor

Description

When a dedicated feed is used to update entry statuses for a site in a site group all entries in that site group across the different sites their statuses are updated.

Expected behavior

Only the entry in the site for which the feed-me feed was set up should be disabled.

Steps to reproduce

  1. Create a site group with three sites (EN, FR, NL)
  2. Create a section with the propagation method 'Save entries to other sites in the same site group'
  3. Create some entries across the different sites for this section
  4. Setup a feed with only id's to match to the entries
    • Set the target site to one of the site in the group (do not use the default global site)
    • Set the default status for the mapping to "use default value" and "disabled"
    • Run the feed
  5. Check the entries and verify they are disabled in the desired site
  6. Now check the other sites, they will be disabled as well

Additional info

  • Craft version: 3.5.19.1
  • PHP version: 7.3.33
  • Database driver & version: MariaDB 10.3.36
  • Plugins & versions: Feed-Me 4.3.6

The following is a simple db & import file for a new setup on Craft 4 with the latest feed-me that demonstrates the issue.
db-and-import-file.zip
@brianjhanson brianjhanson self-assigned this Jan 4, 2023
brianjhanson added a commit that referenced this issue Jan 4, 2023
@brianjhanson
Fix enabled logic
a83804c 
The `enabledForSite` property was getting set correctly, but the
`enabled` property didn't necessarily respect it. This caused elements
to appear as if their status was incorrect and could cause some issues
if you tried to change it via an element action.

Fixes #1208
@brianjhanson brianjhanson mentioned this issue Jan 4, 2023
Merged
@ThomasDeMarez ThomasDeMarez mentioned this issue Jul 4, 2023
Closed
@ThomasDeMarez
Copy link
Contributor Author

This issue is back for us in 5.1.4.
I was able to create a fix for this in #1345

@i-just i-just mentioned this issue Nov 17, 2023
Merged
@angrybrad
Copy link
Member

Fixed for the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianjhanson brianjhanson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix enabled logic craftcms/feed-me
3 participants
@angrybrad @brianjhanson @ThomasDeMarez