-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Read-only settings #3846
Merged
lukeholder
merged 17 commits into
5.3
from
feature/show-read-only-settings-when-allowadminchanges-false
Jan 22, 2025
Merged
[5.3] Read-only settings #3846
lukeholder
merged 17 commits into
5.3
from
feature/show-read-only-settings-when-allowadminchanges-false
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inchanges-false # Conflicts: # src/controllers/GatewaysController.php # src/templates/settings/gateways/index.twig
lukeholder
deleted the
feature/show-read-only-settings-when-allowadminchanges-false
branch
January 22, 2025 14:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Notes
Use the new
disableInputs()
helper if needed:return Html::disableInputs(fn() => $this->getSettingsHtml());
getReadOnlySettingsResponse()
toPlugin
.\craft\commerce\Plugin::$hasReadOnlyCpSettings
\craft\commerce\controllers\BaseAdminController::isReadyOnlyScreen()
helper.$this->requireAdmin(false);
inBaseAdminController
Controllers
Make sure
$this->isReadyOnlyScreen()
is passed into templates/screens for all admin based controllers:Templates
Use
readOnly
variable available from controller or{% set readOnly = not craft.app.config.general.allowAdminChanges %}
.Disable inputs:
disabled: readOnly,
orstatic: readOnly,
.Disable actions for admin tables
Fields
Related issues
craftcms/cms#16265