-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delta updates #5146
Delta updates #5146
Conversation
- fieldAttributes (alternative to the attr block) - labelAttributes
- Only submit entry fields that were changed in some way - Elements keep track of dirty field values - Skip updating content values for non-dirty fields - Matrix & relational fields skip post-save element processing if their field values aren't dirty
# Conflicts: # src/web/assets/cp/dist/js/Craft.js # src/web/assets/cp/dist/js/Craft.min.js # src/web/assets/cp/dist/js/Craft.min.js.map
If a block-style field that supports delta updates is nested in another block-style field that doesn't support delta updates, no delta input names should be registered
I just wanted to say that this is awesome and it's working great in my tests! Gonna casually drop some ideas...
|
@Mosnar Great ideas!
We’d also have to start tracking other element properties for this to work effectively. Otherwise let’s say you have a cached template that outputs an entry’s author, and then edit the entry to change the author (without modifying custom field values), the cache wouldn’t get cleared. We could track whether any element properties besides their custom fields were accessed, but at that point there’s not much to gain here. That said, we’re probably going to swap out the entire template caching system with something else in Craft 4, so I’ll keep this in mind for that.
The plan to fix #4642 is going to involve keeping track of custom field changes, and we’ll likely find a way to show what’s changed within the UI, so this should be unnecessary.
Yeah it will probably be needed from time to time. I think I’ll make it possible from
Yeah we should definitely do that. |
Will resolve #4064, #4149, and pave the way for a proper fix for #4642.