Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store empty entry types props as null in the PC #16273

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Dec 4, 2024

Description

When the project config is generated via save in the control panel, the entry type yaml file has the icon, titleTranslationKeyFormat, titleFormat and slugTranslationKeyFormat saved as an empty string. When the project-config/rebuild command is run, they are stored as null.

The PR ensures that, in both cases, an empty value is stored as null.

(applicable to v5 only; already stores the existing empty values as null in v4)

Related issues

#16266

@i-just i-just requested a review from brandonkelly December 4, 2024 10:55
@brandonkelly brandonkelly merged commit 57f2235 into 5.x Dec 5, 2024
@brandonkelly brandonkelly deleted the bugfix/16266-pc-config-empty-string-and-null branch December 5, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants