Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Allow custom colors” Color field setting #16249

Merged

Conversation

brandonkelly
Copy link
Member

@brandonkelly brandonkelly commented Dec 1, 2024

Description

Replaces Color fields’ Presets setting with “Palette”, and adds a new “Allow custom colors” setting.

The new Palette and “Allow custom colors” settings

“Allow custom colors” will be enabled for existing Color fields, and disabled for new Color fields by default.

Color fields without any Palette colors will continue presenting how they always have, as a manual color input.

Otherwise, they will present as a color select input, similar to the one within entry type settings, filled with the preset colors.

An expanded Color field

If “Allow custom colors” is enabled, a “Custom color…” option will be listed at the end. When that’s selected, a color input will be displayed below.

A Color field with a custom color value

Related issues

Copy link

linear bot commented Dec 1, 2024

Copy link
Contributor

@gcamacho079 gcamacho079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The Selectize dropdown does not have an accessible name. Because the dropdown is immediately adjacent to the legend and it makes visual sense that it would be the name of the dropdown, you can reference the legend ID from the input's aria-labelledby attribute to give it an accessible name.
  • When the “Custom color…” option is selected, tabbing back into the Selectize dropdown causes the custom color part of the form to disappear, affecting keyboard usability. To recreate:
    • Have the custom color option selected
    • From the previous focusable element, tab forward through the UI so that focus lands on Selectize dropdown
    • Continue tabbing. Keyboard focus should have skipped past the custom color inputs, and you have to tab backwards to interact with them
      Expected behavior: keyboard focus should land on the custom color inputs immediately after the Selectize.
  • The lack of visible, adjacent labels that match the custom color inputs can cause issues for voice control users. I suggest adding visible, adjacent labels to both the "Color picker" and "Hex value" inputs that exactly match, or are part of, each input's accessible name. (See WebAIM contrast checker for potential layout)
  • At 320px wide screens, the Selectize dropdown overflows the body container

Copy link
Contributor

@gcamacho079 gcamacho079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brandonkelly brandonkelly merged commit 77bc5df into 5.6 Dec 10, 2024
@brandonkelly brandonkelly deleted the feature/cms-1305-allow-custom-colors-setting-for-color-field branch December 10, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants