Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default connect_timeout of 15 seconds for all craftnet Api requests #15571

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

angrybrad
Copy link
Member

Guzzle connect_timeout defaults to 0, which means to wait indefinitely.

This can be a problem if a client has connection issues connecting to our API endpoint, or our endpoint is down.

@brandonkelly brandonkelly merged commit 5d2fd35 into 4.x Aug 21, 2024
@brandonkelly brandonkelly deleted the bugfix/guzzle-timeout branch August 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants