Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide field handle for entryType #13659

Closed
wants to merge 1 commit into from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Sep 7, 2023

Description

PR #13138 added missing validation messages to the meta fields. In the process, it was necessary to add the attribute param to the Entry Type select field to trigger the containing div to have the data-attribute="typeId" attribute, which is needed for the validation errors to show in a slideout.

Adding attribute, however, makes the field handle show for the Entry Type field when the user has “Show field handles in edit forms” enabled, and this wasn’t the case before (nor should it be).

This PR removes the attribute from the Entry Type select field and replaces it with fieldAttributes[data][attribute], which will give the field container the correct attribute for the error messages to show in a slideout, without making the field handle show.

Related issues

#13627

@brandonkelly
Copy link
Member

Fixed this in a different way via 565eaa2 – I’d rather have CustomField have to do a little extra work explicitly stating that its “attribute” should be shown on edit forms, rather than make every other field layout field have to identify its attribute in a more complicated way.

@brandonkelly brandonkelly deleted the bugfix/13627-hide-field-handle-for-entryType branch September 11, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants