Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce "signing in" state on login screen #12386

Merged
merged 15 commits into from
Jan 11, 2023
Merged

Conversation

gcamacho079
Copy link
Contributor

Description

Adds a new Garnish component for a Multi-Function Button that:

  • Announces loading state via a live region located before the button element
  • Updates live region for success and failure states via data- attributes attached to the button element

Related issues

Resolves DEV-1047

@linear
Copy link

linear bot commented Nov 28, 2022

DEV-1047 Sign in

@gcamacho079 gcamacho079 marked this pull request as ready for review November 28, 2022 21:53
@gcamacho079 gcamacho079 requested review from benjamindavid and a team as code owners November 28, 2022 21:53
@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Nov 28, 2022
@gcamacho079
Copy link
Contributor Author

Back to in-progress

@gcamacho079 gcamacho079 reopened this Nov 30, 2022
gcamacho079 and others added 4 commits November 30, 2022 10:26
# Conflicts:
#	src/web/assets/garnish/dist/garnish.js
#	src/web/assets/garnish/dist/garnish.js.map
#	src/web/assets/login/dist/login.js.map
#	src/web/assets/pluginstore/dist/css/app.css
#	src/web/assets/pluginstore/dist/css/app.css.map
#	src/web/assets/pluginstore/dist/js/app.js
#	src/web/assets/pluginstore/dist/js/app.js.map
[ci skip]
@brandonkelly brandonkelly merged commit 7b95b8e into 4.4 Jan 11, 2023
@brandonkelly brandonkelly deleted the a11y/login-announcement branch January 11, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants