Feature/dev 212 errors summary

src/controllers/ElementsController.php

@@ -403,6 +403,7 @@ public function actionEdit(?ElementInterface $element, ?int $elementId = null):
                 $isDraft
             ))
             ->notice($element->isProvisionalDraft ? fn() => $this->_draftNotice() : null)
+            ->errorsSummary(fn() => $this->_errorsSummary($element))
             ->prepareScreen(
                 fn(Response $response, string $containerId) => $this->_prepareEditor(
                     $element,
@@ -802,6 +803,42 @@ private function _editorContent(
         return $html;
     }
 
+    private function _errorsSummary(
+        ElementInterface $element,
+    ): string {
+        $html = '';
+
+        if ($element->hasErrors()) {
+            $errorsList = [];
+            foreach ($element->getErrors() as $errors) {
+                foreach ($errors as $error) {
+                    $errorsList[] = Html::tag('li', Craft::t('app', $error));
+                }
+            }
+
+            if (!empty($errorsList)) {
+                $heading = Craft::t('app', 'Found {num, number} {num, plural, =1{error} other{errors}}:', [
+                    'num' => count($errorsList),
+                ]);
+
+                $html = Html::beginTag('div', [
+                        'class' => ['errors-summary'],
+                    ]) .
+                    Html::beginTag('h2') .
+                    $heading .
+                    Html::endTag('h2') .
+                    Html::beginTag('ul', [
+                        'class' => ['errors'],
+                    ]) .
+                    implode('', $errorsList) .
+                    Html::endTag('ul') .
+                    Html::endTag('div');
+            }
+        }
+
+        return $html;
+    }
+
     private function _editorSidebar(
         ElementInterface $element,
         bool $mergedCanonicalChanges,
@@ -888,7 +925,7 @@ public function actionSave(): ?Response
         }
 
         try {
-            $success = $elementsService->saveElement($element);
+            $success = $elementsService->saveElement($element, crossSiteValidate: Craft::$app->getIsMultiSite());
         } catch (UnsupportedSiteException $e) {
             $element->addError('siteId', $e->getMessage());
             $success = false;
@@ -1280,7 +1317,7 @@ public function actionApplyDraft(): ?Response
             $element->setScenario(Element::SCENARIO_LIVE);
         }
 
-        if (!$elementsService->saveElement($element)) {
+        if (!$elementsService->saveElement($element, crossSiteValidate: Craft::$app->getIsMultiSite())) {
             return $this->_asAppyDraftFailure($element);
         }
 

src/services/Elements.php

@@ -50,6 +50,7 @@
 use craft\helpers\ElementHelper;
 use craft\helpers\Queue;
 use craft\helpers\StringHelper;
+use craft\helpers\UrlHelper;
 use craft\i18n\Translation;
 use craft\queue\jobs\FindAndReplace;
 use craft\queue\jobs\UpdateElementSlugsAndUris;
@@ -1026,7 +1027,7 @@ public function getEnabledSiteIdsForElement(int $elementId): array
      * @throws Exception if the $element doesn’t have any supported sites
      * @throws Throwable if reasons
      */
-    public function saveElement(ElementInterface $element, bool $runValidation = true, bool $propagate = true, ?bool $updateSearchIndex = null): bool
+    public function saveElement(ElementInterface $element, bool $runValidation = true, bool $propagate = true, ?bool $updateSearchIndex = null, ?bool $crossSiteValidate = false): bool
     {
         // Force propagation for new elements
         $propagate = !$element->id || $propagate;
@@ -1035,7 +1036,7 @@ public function saveElement(ElementInterface $element, bool $runValidation = tru
         $duplicateOf = $element->duplicateOf;
         $element->duplicateOf = null;
 
-        $success = $this->_saveElementInternal($element, $runValidation, $propagate, $updateSearchIndex);
+        $success = $this->_saveElementInternal($element, $runValidation, $propagate, $updateSearchIndex, crossSiteValidate: $crossSiteValidate);
         $element->duplicateOf = $duplicateOf;
         return $success;
     }
@@ -2760,6 +2761,7 @@ private function _saveElementInternal(
         ?bool $updateSearchIndex = null,
         ?array $supportedSites = null,
         bool $forceTouch = false,
+        bool $crossSiteValidate = false,
     ): bool {
         /** @var ElementInterface|DraftBehavior|RevisionBehavior $element */
         $isNewElement = !$element->id;
@@ -3020,7 +3022,9 @@ private function _saveElementInternal(
                         // Skip the initial site
                         if ($siteId != $element->siteId) {
                             $siteElement = $siteElements[$siteId] ?? false;
-                            $this->_propagateElement($element, $supportedSites, $siteId, $siteElement);
+                            if (!$this->_propagateElement($element, $supportedSites, $siteId, $siteElement, crossSiteValidate: $crossSiteValidate)) {
+                                return false;
+                            }
                         }
                     }
                 }
@@ -3153,14 +3157,17 @@ private function _saveElementInternal(
      * @param array $supportedSites The element’s supported site info, indexed by site ID
      * @param int $siteId The site ID being propagated to
      * @param ElementInterface|false|null $siteElement The element loaded for the propagated site
+     * @param bool $crossSiteValidate Whether we should "live" validate the element across all sites
+     * @retrun bool
      * @throws Exception if the element couldn't be propagated
      */
     private function _propagateElement(
         ElementInterface $element,
         array $supportedSites,
         int $siteId,
         ElementInterface|false|null $siteElement = null,
-    ) {
+        bool $crossSiteValidate = false,
+    ): bool {
         // Make sure the element actually supports the site it's being saved in
         if (!isset($supportedSites[$siteId])) {
             throw new UnsupportedSiteException($element, $siteId, 'Attempting to propagate an element to an unsupported site.');
@@ -3241,17 +3248,71 @@ private function _propagateElement(
 
         // Save it
         $siteElement->setScenario(Element::SCENARIO_ESSENTIALS);
+
+        // for Entries and Categories: validate element against "live" scenario across all sites,
+        // if element is to be set to live/pending/enabled
+        if ($crossSiteValidate && ($siteElement instanceof Entry || $siteElement instanceof Category)) {
+            $siteElementStatus = $siteElement->getStatus();
+            if (($siteElement instanceof Entry &&
+                    ($siteElementStatus === Entry::STATUS_LIVE || $siteElementStatus === Entry::STATUS_PENDING)
+                ) ||
+                ($siteElement instanceof Category && $siteElementStatus === Category::STATUS_ENABLED)
+            ) {
+                $siteElement->setScenario(Element::SCENARIO_LIVE);
+            }
+        }
+
         $siteElement->propagating = true;
 
-        if ($this->_saveElementInternal($siteElement, true, false, null, $supportedSites) === false) {
-            // Log the errors
-            $error = 'Couldn’t propagate element to other site due to validation errors:';
-            foreach ($siteElement->getFirstErrors() as $attributeError) {
-                $error .= "\n- " . $attributeError;
+        if ($this->_saveElementInternal($siteElement, true, false, null, $supportedSites, crossSiteValidate: $crossSiteValidate) === false) {
+            // if the element we're trying to save has validation errors, notify original element about them
+            if ($siteElement->hasErrors()) {
+                return $this->_crossSiteValidationErrors($siteElement, $element);
+            } else {
+                // Log the errors
+                $error = 'Couldn’t propagate element to other site due to validation errors:';
+                foreach ($siteElement->getFirstErrors() as $attributeError) {
+                    $error .= "\n- " . $attributeError;
+                }
+                Craft::error($error);
+                throw new Exception('Couldn’t propagate element to other site.');
             }
-            Craft::error($error);
-            throw new Exception('Couldn’t propagate element to other site.');
         }
+
+        return true;
+    }
+
+    /**
+     * @param ElementInterface $siteElement
+     * @param ElementInterface $element
+     * @return bool
+     * @throws Throwable
+     */
+    private function _crossSiteValidationErrors(
+        ElementInterface $siteElement,
+        ElementInterface $element,
+    ): bool {
+        // get site we're propagating to
+        $propagateToSite = Craft::$app->getSites()->getSiteById($siteElement->siteId);
+        $user = Craft::$app->getUser()->getIdentity();
+        $message = Craft::t('app', 'Validation errors for site {siteName}', [
+            'siteName' => $propagateToSite->name,
+        ]);
+
+        // check user can edit this element for the site that throws validation error on propagation
+        if ($user &&
+            Craft::$app->getIsMultiSite() &&
+            $user->can("editSite:{$propagateToSite->uid}") &&
+            $siteElement->canSave($user)
+        ) {
+            $queryParams = ArrayHelper::without(Craft::$app->getRequest()->getQueryParams(), 'site');
+            $url = UrlHelper::url($siteElement->getCpEditUrl(), $queryParams + ['prevalidate' => 1]);
+            $message .= " <a href=\"$url\">(" . Craft::t('app', 'View') . ")</a>";
+        }
+
+        $element->addError('global', $message);
+
+        return false;
     }
 
     /**

src/templates/_layouts/cp.twig

@@ -74,6 +74,7 @@
 {% set footer = (footer ?? block('footer') ?? '')|trim %}
 {% set crumbs = crumbs ?? null %}
 {% set tabs = (tabs ?? [])|length > 1 ? tabs : null %}
+{% set errorsSummary = errorsSummary ?? null %}
 
 {% set mainContentClasses = [
     sidebar ? 'has-sidebar',
@@ -247,6 +248,9 @@
                                 <h2 id="content-heading"></h2>
                             {% endif %}
                             {% block main %}
+                                {% if errorsSummary is not empty %}
+                                    {{ errorsSummary is defined ? errorsSummary|raw }}
+                                {% endif %}
                                 <div id="content" class="content-pane">
                                     {% if contentNotice or tabs %}
                                         <header id="content-header" class="pane-header">

src/translations/en/app.php

@@ -663,6 +663,7 @@
     'Forgot your password?' => 'Forgot your password?',
     'Format' => 'Format',
     'Formatting Locale' => 'Formatting Locale',
+    'Found {num, number} {num, plural, =1{error} other{errors}}:' => 'Found {num, number} {num, plural, =1{error} other{errors}}:',
     'Free' => 'Free',
     'From {date}' => 'From {date}',
     'From' => 'From',

src/web/CpScreenResponseBehavior.php

@@ -182,6 +182,13 @@ class CpScreenResponseBehavior extends Behavior
      */
     public $notice = null;
 
+    /**
+     * @var string|callable|null The errors summary HTML (DEV-212).
+     * @see errorsSummary()
+     * @see errorsSummaryTemplate()
+     */
+    public $errorsSummary = null;
+
     /**
      * Sets a callable that will be called before other properties are added to the screen.
      *
@@ -594,4 +601,30 @@ public function noticeTemplate(string $template, array $variables = []): Respons
             fn() => Craft::$app->getView()->renderTemplate($template, $variables, View::TEMPLATE_MODE_CP)
         );
     }
+
+    /**
+     * Sets the errors summary HTML.
+     *
+     * @param callable|string|null $value
+     * @return Response
+     */
+    public function errorsSummary(callable|string|null $value): Response
+    {
+        $this->errorsSummary = $value;
+        return $this->owner;
+    }
+
+    /**
+     * Sets a template that should be used to render the errors summary HTML.
+     *
+     * @param string $template
+     * @param array $variables
+     * @return Response
+     */
+    public function errorsSummaryTemplate(string $template, array $variables = []): Response
+    {
+        return $this->errorsSummary(
+            fn() => Craft::$app->getView()->renderTemplate($template, $variables, View::TEMPLATE_MODE_CP)
+        );
+    }
 }

src/web/CpScreenResponseFormatter.php

@@ -82,6 +82,8 @@ private function _formatJson(\yii\web\Request $request, YiiResponse $response, C
 
         $sidebar = $behavior->sidebar ? $view->namespaceInputs($behavior->sidebar, $namespace) : null;
 
+        $errorsSummary = $behavior->errorsSummary ? $view->namespaceInputs($behavior->errorsSummary, $namespace) : null;
+
         $response->data = [
             'editUrl' => $behavior->editUrl,
             'namespace' => $namespace,
@@ -92,6 +94,7 @@ private function _formatJson(\yii\web\Request $request, YiiResponse $response, C
             'action' => $behavior->action,
             'content' => $content,
             'sidebar' => $sidebar,
+            'errorsSummary' => $errorsSummary,
             'headHtml' => $view->getHeadHtml(),
             'bodyHtml' => $view->getBodyHtml(),
             'deltaNames' => $view->getDeltaNames(),
@@ -115,6 +118,7 @@ private function _formatTemplate(YiiResponse $response, CpScreenResponseBehavior
         $notice = is_callable($behavior->notice) ? call_user_func($behavior->notice) : $behavior->notice;
         $content = is_callable($behavior->content) ? call_user_func($behavior->content) : ($behavior->content ?? '');
         $sidebar = is_callable($behavior->sidebar) ? call_user_func($behavior->sidebar) : $behavior->sidebar;
+        $errorsSummary = is_callable($behavior->errorsSummary) ? call_user_func($behavior->errorsSummary) : $behavior->errorsSummary;
 
         if ($behavior->action) {
             $content .= Html::actionInput($behavior->action, [
@@ -154,6 +158,7 @@ private function _formatTemplate(YiiResponse $response, CpScreenResponseBehavior
                 'contentNotice' => $notice,
                 'content' => $content,
                 'details' => $sidebar,
+                'errorsSummary' => $errorsSummary,
             ],
             'templateMode' => View::TEMPLATE_MODE_CP,
         ]);

src/web/assets/cp/CpAsset.php

@@ -187,6 +187,7 @@ private function _registerTranslations(View $view): void
             'Folder deleted.',
             'Folder renamed.',
             'Format',
+            'Found {num, number} {num, plural, =1{error} other{errors}}:',
             'From {date}',
             'From',
             'Give your tab a name.',

src/web/assets/cp/src/js/CpScreenSlideout.js

@@ -517,6 +517,7 @@ Craft.CpScreenSlideout = Craft.Slideout.extend(
       Craft.cp.displayError(data.message);
       if (data.errors) {
         this.showErrors(data.errors);
+        this.showErrorsSummary(data.errors);
       }
     },
 
@@ -539,6 +540,23 @@ Craft.CpScreenSlideout = Craft.Slideout.extend(
       this.fieldsWithErrors.forEach(($field) => {
         Craft.ui.clearErrorsFromField($field);
       });
+      Craft.ui.clearErrorsSummary(this.$body);
+    },
+
+    /**
+     * @param {string[]} errors
+     */
+    showErrorsSummary: function (errors) {
+      var allErrors = [];
+      Object.values(errors).forEach((fieldErrors) => {
+        for (var i = 0; i < fieldErrors.length; i++) {
+          allErrors.push(fieldErrors[i]);
+        }
+      });
+
+      if (allErrors.length > 0) {
+        Craft.ui.showErrorsSummary(this.$body, allErrors);
+      }
     },
 
     isDirty: function () {