Don't require creatorId
#11923
Merged
Don't require creatorId
#11923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjhanson
force-pushed
the
bugfix/dont-require-creatorid
branch
from
5505739 to
9b225b2
Compare
# Conflicts: # CHANGELOG.md
|
Seems pretty safe since it looks like everything else surrounding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops requiring
creatorIdwhen creating a draft.@brandonkelly this might be considered a breaking change because the signature of
\craft\services\Drafts::createDraft()andcraft\events\DraftEventwould change. I'm also not sure if this would have any unintended consequences that I'm not aware of, as far as I can tell the system is okay withcreatorIdbeingnullbut let me know if there are specific areas I should test around this.Related issues
#11904