Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getCurrentUser static #11916

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Make getCurrentUser static #11916

merged 4 commits into from
Sep 13, 2022

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Sep 12, 2022 •
edited
Loading

Method should be static

@timkelty timkelty requested review from benjamindavid and a team as code owners September 12, 2022 04:00
@timkelty timkelty changed the base branch from develop to 4.3 September 12, 2022 04:00
@timkelty timkelty removed the request for review from benjamindavid September 12, 2022 04:00
@brandonkelly brandonkelly merged commit a56ed26 into 4.3 Sep 13, 2022
@brandonkelly brandonkelly deleted the make-current-user-static branch September 13, 2022 16:58
@timkelty
Copy link
Contributor Author

timkelty commented Oct 7, 2022

@brandonkelly if we're renaming this from getCurrentUser to currentUser, we need to remove the docblock:

@property-read ?User $currentUser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkelty @brandonkelly