Respect user conditions when building source table column arrays #11913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-995 Hide table columns for inaccessible fields
Any fields with a user condition on them which will prevent the current user from seeing it should be omitted from element index tables. |
[ci skip]
brandonkelly
deleted the
feature/dev-995-hide-table-columns-for-inaccessible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks to ensure we’re only showing table columns for custom fields that are actually visible to the current user, based on field layouts’ user conditions.
(Only applies to non-admins. Even if a condition does exclude an admin from seeing a field, the admin still has other ways of seeing it, and needs to know about it so they can choose to include the field in the source’s Table Columns setting.)