Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting the escape key during install closes the installer modal #4307

Closed
Mosnar opened this issue May 24, 2019 · 1 comment
Closed

Hitting the escape key during install closes the installer modal #4307

Mosnar opened this issue May 24, 2019 · 1 comment

Comments

@Mosnar
Copy link
Contributor

Mosnar commented May 24, 2019

Description

If you hit the Esc key during the installation (it was an accident!), the setup modal will close. Clicking the "Install" button will show the modal but it progresses to the next step. In my case, I had not finished configuring the install and the next step was to run the migrations.

Steps to reproduce

  1. Start a fresh install from web GUI
  2. When you get to the input portion, hit the Esc key

The modal should probably be locked to prevent closing or the installation process should be reset when closed.

Additional info

  • Craft version: 3.1.x
  • PHP version: N/A
  • Database driver & version: N/A
  • Plugins & versions: N/A
@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants