Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Adding matrix blocks: Incorrect translations #14573

Closed
wsydney76 opened this issue Mar 12, 2024 · 9 comments
Closed

[5.x]: Adding matrix blocks: Incorrect translations #14573

wsydney76 opened this issue Mar 12, 2024 · 9 comments
Labels

Comments

@wsydney76
Copy link

wsydney76 commented Mar 12, 2024

What happened?

Description

Buttons are labeled with wrong grammatical articles in German:

Matrix field with multiple entry types (cards):

image

Has to be 'Neuer Eintrag'

Matrix field with multiple entry types (inline):

image

Translation missing? Would have to be 'Neuer Block'

Matrix field with single entry type:

image

Has to be 'Neuer Standort' in this case.

  • Keep upper case in place
  • There is no way in German (and probably other languages) to automatically create a correct caption:
    • New location -> Neuer Standort
    • New role -> Neue Rolle
    • New document -> Neues Dokument

Could be 'xyz hinzufügen' (add xyz), like in relational fields.

And another argument to make this configurable.

PS.
And a missing translation here:

image

Steps to reproduce

  1. Create matrix field
  2. Set CP language to German

Expected behavior

Correct language

Actual behavior

Wrong, unprofessional-looking language

Craft CMS version

Craft Solo 5.0.x-dev

PHP version

8.2.13

Operating system and version

Linux 5.15.133.1-microsoft-standard-WSL2

Database type and version

MySQL 8.0.33

Image driver and version

No response

Installed plugins and versions

@wsydney76 wsydney76 added the bug label Mar 12, 2024
@brandonkelly
Copy link
Member

Matrix field with multiple entry types (cards):

image

Has to be 'Neuer Eintrag'

Is this an issue in Craft 4 as well, then (e.g. from the Entries index page)?

Matrix field with multiple entry types (inline):

image

Translation missing? Would have to be 'Neuer Block'

We haven’t ordered new translations for Craft 5 quite yet.

And another argument to make this configurable.

Yep, been meaning to do that. Just got around to it for the next release. Going forward Matrix fields will have a “New” Button Label setting, where you can set exactly what the button label should be.

@brandonkelly
Copy link
Member

5.0.0-beta.7 is out now with that new Matrix setting.

@wsydney76
Copy link
Author

@brandonkelly Great, thanks.

Is this an issue in Craft 4 as well, then (e.g. from the Entries index page)?

No, that's correct in Craft 4 and 5

image

PS. There is (and I think always has been) a minor translation issue

image

should be 'Einträgen' (genitiv). Does'nt get into focus so much, so probably gets ignored. Would be ok for me if the word is simply omitted, as there is no additional value in it.

@brandonkelly
Copy link
Member

  • Keep upper case in place

Is this a stylistic preference, or is Eintrag a “proper noun” that must be capitalized?

@wsydney76
Copy link
Author

@brandonkelly

Every noun is always capitalized in German, without exception, see Wikipedia article about this and other weirdnesses.

@brandonkelly
Copy link
Member

Good to know!

brandonkelly added a commit that referenced this issue Mar 13, 2024
Go all-in on using "New {type}" for element types, so we have a central place to manage special cases like #14573
@brandonkelly
Copy link
Member

I’ve updated the German New {type} translation so it will output Neuer when type is Eintrag or Benutzer. (9a670fd, 7c4135b)

I’ve also removed all of the element type-specific New X messages (New category, New entry, New global set, and New user) in favor of using New {type}, so any additional special cases can be handled centrally and we don’t have to worry about some things being translated inconsistently. (5e7dca6)

@youwebmax
Copy link

Hi, can you please also adjust this translation for the language de-CH? The same rules apply as in de.

@brandonkelly
Copy link
Member

@youwebmax I’ve made that change in CrowdIn for the next release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants