Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0-beta.3]: Thumb image missing in 'My Drafts' dashboard widget #14486

Closed
wsydney76 opened this issue Feb 27, 2024 · 5 comments
Closed

[5.0.0-beta.3]: Thumb image missing in 'My Drafts' dashboard widget #14486

wsydney76 opened this issue Feb 27, 2024 · 5 comments
Assignees
Labels

Comments

@wsydney76
Copy link

What happened?

Description

In the 'My Drafts' widget, thumbnail images are not shown:

image

This is how a part of the html markup looks like (present in all cardlets):

<div class="thumb" data-sizes="calc(30rem/16)" data-srcset="https://craft50.ddev.site/files/images/featured/_30x16_crop_center-center_none/Schneewittchen-Remake1.jpg?v=1698323264%2C0.7724%2C0.3285 30w, https://craft50.ddev.site/files/images/featured/_60x33_crop_center-center_none/Schneewittchen-Remake1.jpg?v=1698323264%2C0.7724%2C0.3285 60w"></div>

There is no JavaScript error.

Steps to reproduce

  1. See image

Expected behavior

Images are shown (I suspect...)

Actual behavior

They are not.

Craft CMS version

5.0.x-dev as 5.0.0-beta.3

PHP version

8.2.13

Operating system and version

Linux 5.15.133.1-microsoft-standard-WSL2

Database type and version

No response

Image driver and version

Imagick 3.7.0 (ImageMagick 6.9.11-60)

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Feb 28, 2024

Hi, thanks for reporting! I raised a PR for this.

@brandonkelly
Copy link
Member

Craft 5.0.0-beta.4 is out with this fix. Thanks again!

@wsydney76
Copy link
Author

Thanks, However, thumbs still don't load on initial page load for me:

image

After editing and saving settings, they appear:

image

5.0.0-beta.4, no active plugins, no JS error.

brandonkelly added a commit that referenced this issue Mar 1, 2024
Shouldn’t have been removed in 4fea707

Fixes #14486
@brandonkelly
Copy link
Member

Doh… that was fixed in @i-just’s original PR, but I removed the change thinking the real issue was after saving settings. I guess it was a two-part bug and both fixes were needed. Just brought her change back for the next release.

@brandonkelly
Copy link
Member

5.0.0-beta.5 is out with the second half of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants