Allow disabling entry propagation for Structure sections

Resolves #2386
craftcms · Oct 19, 2018 · bb334aa · bb334aa
1 parent e37a58e
commit bb334aa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Added
+- Structure sections now have the ability to disable entry propagation, like Channel sections. ([#2386](https://github.com/craftcms/cms/issues/2386))
+
 ### Changed
 - `craft\base\Field::supportedTranslationMethods()` now defaults to only returning `none` if the field type doesn’t have a content column. ([#3385](https://github.com/craftcms/cms/issues/3385))
 - Craft.EntryTypeSwitcher now fires a `beforeTypeChange` event before swapping the Edit Entry form tabs. ([#3375](https://github.com/craftcms/cms/pull/3375))

diff --git a/src/services/Sections.php b/src/services/Sections.php
@@ -479,7 +479,7 @@ public function saveSection(Section $section, bool $runValidation = true): bool
         }
 
         // Main section settings
-        if ($section->type !== Section::TYPE_CHANNEL) {
+        if ($section->type === Section::TYPE_SINGLE) {
             $section->propagateEntries = true;
         }
 

diff --git a/src/templates/settings/sections/_edit.html b/src/templates/settings/sections/_edit.html
@@ -139,7 +139,7 @@
     }) }}
 
     {% if craft.app.getIsMultiSite() %}
-        <div class="type-channel {% if section.type != 'channel' %}hidden{% endif %}">
+        <div class="field type-channel type-structure {% if section.type == 'single' %}hidden{% endif %}">
             {{ forms.checkboxField({
                 label: 'Propagate entries across all enabled sites?'|t('app'),
                 instructions: 'Whether entries should be propagated across all the sites the section is enabled in. If this is disabled, each entry will only belong to the site it was created in.'|t('app'),
@@ -151,7 +151,7 @@
         </div>
     {% endif %}
 
-    <div class="type-structure {% if section.type != 'structure' %}hidden{% endif %}">
+    <div class="field type-structure {% if section.type != 'structure' %}hidden{% endif %}">
         {{ forms.textField({
             label: "Max Levels"|t('app'),
             instructions: "The maximum number of levels this section can have. Leave blank if you don’t care."|t('app'),