Cache getPrev() and getNext() ID queries

craftcms · Dec 14, 2024 · b8db7a7 · b8db7a7
1 parent 255dbe8
commit b8db7a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft CMS 4
 
+## Unreleased
+
+- Fixed a bug where elements’ `getPrev()` and `getNext()` methods could cause duplicate queries. ([#16329](https://github.com/craftcms/cms/discussions/16329))
+
 ## 4.13.6 - 2024-12-10
 
 - Fixed a bug where blank user group descriptions weren’t getting omitted from project config data. ([#16272](https://github.com/craftcms/cms/pull/16272))

diff --git a/src/base/Element.php b/src/base/Element.php
@@ -5500,7 +5500,7 @@ private function _getRelativeElement(mixed $criteria, int $dir): ?ElementInterfa
         }
 
         /** @var ElementQuery $query */
-        $elementIds = $query->ids();
+        $elementIds = $query->cache()->ids();
         $key = array_search($this->getCanonicalId(), $elementIds, false);
 
         if ($key === false || !isset($elementIds[$key + $dir])) {