Improved humanDurationFromInterval()

craftcms · Jun 6, 2018 · b0e6963 · b0e6963
1 parent 96c420d
commit b0e6963
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -1,5 +1,10 @@
 # Release Notes for Craft CMS 3.x
 
+## Unreleased
+
+### Changed
+- Improved the output of `craft\helpers\DateTimeHelper::humanDurationFromInterval()`.
+
 ## 3.0.10.1 - 2018-06-06
 
 ### Fixed

diff --git a/src/helpers/DateTimeHelper.php b/src/helpers/DateTimeHelper.php
@@ -639,7 +639,18 @@ public static function humanDurationFromInterval(DateInterval $dateInterval, boo
             $timeComponents[] = $dateInterval->s == 1 ? Craft::t('app', '1 second') : Craft::t('app', '{num} seconds', ['num' => $dateInterval->s]);
         }
 
-        return implode(', ', $timeComponents);
+        $last = array_pop($timeComponents);
+        if (!empty($timeComponents)) {
+            $string = implode(', ', $timeComponents);
+            if (count($timeComponents) > 1) {
+                $string .= ',';
+            }
+            $string .= ' '.Craft::t('app', 'and').' ';
+        } else {
+            $string = '';
+        }
+        $string .= $last;
+        return $string;
     }
 
     // Private Methods