Properly calculate height of transformed images

Fixes an issue where the height of a non-cropped image being transformed was being calculated as a percentage of the height rather than of the width. #11837
craftcms · Aug 30, 2022 · aa26335 · aa26335
1 parent d3ea1fe
commit aa26335
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Release Notes for Craft CMS 3.x
 
+## Unreleased
+
+### Fixed
+- Fixed an issue where image dimensions could be calculated incorrectly. ([#11837](https://github.com/craftcms/cms/issues/11837)) 
+
 ## 3.7.53.1 - 2022-08-26
 
 ### Fixed

diff --git a/src/elements/Asset.php b/src/elements/Asset.php
@@ -2198,7 +2198,7 @@ private function _dimensions($transform = null): array
                 return [$this->_width, $this->_height];
             }
 
-            return $transformRatio > 1 ? [$this->_width, round($this->_height / $transformRatio)] : [round($this->_width * $transformRatio), $this->_height];
+            return $transformRatio > 1 ? [$this->_width, round($this->_width / $transformRatio)] : [round($this->_width * $transformRatio), $this->_height];
         }
 
         [$width, $height] = Image::calculateMissingDimension($transform->width, $transform->height, $this->_width, $this->_height);