Fixed #14498

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Fixed a bug where some characters were getting misinterpreted as elisions when normalizing search keywords.
 - Fixed a bug where `craft\helpers\UrlHelper::actionUrl()` was using the site URL rather than the requested URL. ([#14440](https://github.com/craftcms/cms/issues/14440))
+- Fixed a bug where `craft\helpers\Html::parseTagAttribute()` wasn’t handling attribute values with newlines. ([#14498](https://github.com/craftcms/cms/issues/14498))
 
 ## 4.8.0 - 2024-02-26
 

src/helpers/Html.php

@@ -401,7 +401,7 @@ public static function parseTagAttribute(string $html, int $offset = 0, ?int &$s
             // Wrapped in quotes?
             if (isset($html[$offset]) && in_array($html[$offset], ['\'', '"'])) {
                 $q = preg_quote($html[$offset], '/');
-                if (!preg_match("/$q(.*?)$q/A", $html, $m, 0, $offset)) {
+                if (!preg_match("/$q(.*?)$q/sA", $html, $m, 0, $offset)) {
                     // No matching end quote
                     throw new InvalidArgumentException("Malformed HTML tag attribute in string: $html");
                 }

tests/unit/helpers/HtmlHelperTest.php

@@ -423,6 +423,8 @@ public function parseTagAttributesDataProvider(): array
             [false, "<div x-foo='>"],
             [false, '<!-- comment -->'],
             [false, '<?xml?>'],
+            // https://github.com/craftcms/cms/issues/14498
+            [['data' => ['label' => "foo\n\nbar"]], "<div data-label=\"foo\n\nbar\">"],
         ];
     }