Reintroduce autofocus for now

Reverts #12332
Reverts #12406
Resolves #12921

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Input autofocussing has been reintroduced thorughout the control panel. ([#12921](https://github.com/craftcms/cms/discussions/12921))
 - The `|json_encode` Twig filter now calls `craft\helpers\Json::encode()` internally, improving error handling. ([#12919](https://github.com/craftcms/cms/issues/12919))
 - Fixed a JavaScript error that occurred when resolving an asset move conflict. ([#12920](https://github.com/craftcms/cms/issues/12920))
 - Fixed an error that could occur when rebuilding the project config, if there were any custom source definitions for element types that weren’t Composer-installed. ([#12881](https://github.com/craftcms/cms/issues/12881))

src/fieldlayoutelements/TitleField.php

@@ -46,7 +46,7 @@ class TitleField extends TextField
     /**
      * @inheritdoc
      */
-    public bool $autofocus = false;
+    public bool $autofocus = true;
 
     /**
      * @inheritdoc

src/templates/settings/assets/volumes/_edit.twig

@@ -10,6 +10,7 @@
     name: 'name',
     value: volume.name,
     errors: volume.getErrors('name'),
+    autofocus: true,
     required: true,
 }) }}
 

src/templates/settings/categories/_edit.twig

@@ -21,6 +21,7 @@
         name: 'name',
         value: categoryGroup.name,
         errors: categoryGroup.getErrors('name'),
+        autofocus: true,
         required: true,
     }) }}
 

src/templates/settings/email/_index.twig

@@ -49,6 +49,7 @@
         name: 'fromEmail',
         suggestEnvVars: true,
         value: settings.fromEmail,
+        autofocus: true,
         required: true,
         errors: (freshSettings ? null : settings.getErrors('fromEmail'))
     }) }}

src/templates/settings/fields/_edit.twig

@@ -47,6 +47,7 @@
         value: field.name,
         errors: field.getErrors('name'),
         required: true,
+        autofocus: true
     }) }}
 
     {{ forms.textField({

src/templates/settings/filesystems/_edit.twig

@@ -9,6 +9,7 @@
     name: 'name',
     value: (filesystem is defined ? filesystem.name : null),
     errors: (filesystem is defined ? filesystem.getErrors('name') : null),
+    autofocus: true,
     required: true,
 }) }}
 

src/templates/settings/globals/_edit.twig

@@ -18,6 +18,7 @@
         name: 'name',
         value: globalSet.name,
         errors: globalSet.getErrors('name'),
+        autofocus: true,
         required: true,
     }) }}
 

src/templates/settings/sections/_edit.twig

@@ -38,6 +38,7 @@
         name: 'name',
         value: section.name,
         errors: section.getErrors('name'),
+        autofocus: true,
         required: true,
     }) }}
 

src/templates/settings/sites/_edit.twig

@@ -31,6 +31,7 @@
             value: site.getName(false),
             suggestEnvVars: true,
             errors: site.getErrors('name'),
+            autofocus: true,
             required: true,
         }) }}
 

src/templates/settings/tags/_edit.twig

@@ -18,6 +18,7 @@
         name: 'name',
         value: tagGroup.name,
         errors: tagGroup.getErrors('name'),
+        autofocus: true,
         required: true,
     }) }}
 

src/templates/users/_accountfields.twig

@@ -8,6 +8,7 @@
         id: 'username',
         name: 'username',
         value: (user is defined ? user.username : null),
+        autofocus: true,
         autocomplete: false,
         autocapitalize: false,
         disabled: static or (isNewUser or (currentUser.admin or user.getIsCurrent()) ? false : true),

src/web/assets/cp/src/js/BaseElementIndex.js

@@ -293,6 +293,11 @@ Craft.BaseElementIndex = Garnish.Base.extend(
         }
       });
 
+      // Auto-focus the Search box
+      if (!Garnish.isMobileBrowser(true)) {
+        this.$search.trigger('focus');
+      }
+
       // View menus
       this.viewMenus = {};
 

src/web/assets/cp/src/js/Tabs.js

@@ -42,12 +42,12 @@ Craft.Tabs = Garnish.Base.extend({
         this.addListener($a, 'keydown', (ev) => {
           if ([Garnish.SPACE_KEY, Garnish.RETURN_KEY].includes(ev.keyCode)) {
             ev.preventDefault();
-            this.selectTab(ev.currentTarget, true);
+            this.selectTab(ev.currentTarget);
           }
         });
         this.addListener($a, 'click', (ev) => {
           ev.preventDefault();
-          this.selectTab(ev.currentTarget, true);
+          this.selectTab(ev.currentTarget);
         });
       }
 
@@ -108,7 +108,7 @@ Craft.Tabs = Garnish.Base.extend({
     });
   },
 
-  selectTab: function (tab, focusTab = false) {
+  selectTab: function (tab, focusTab = true) {
     const $tab = this._getTab(tab);
 
     if ($tab[0] === this.$selectedTab[0]) {