Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only render nested entries if they're live #247

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jun 12, 2024

Description

Only render nested entries (in the front end) if they’re live.

CP view:
Screenshot 2024-06-12 at 16 21 02

Before:
Screenshot 2024-06-12 at 16 20 02

After:
Screenshot 2024-06-12 at 16 19 50

Related issues

#246

@i-just i-just requested a review from brandonkelly as a code owner June 12, 2024 15:21
@brandonkelly brandonkelly merged commit 2a7e5d9 into 4.x Jun 12, 2024
3 checks passed
@brandonkelly brandonkelly deleted the bugfix/246-nested-entries-rendering branch June 12, 2024 15:28
@brandonkelly
Copy link
Member

Decided to revert this, and filter out disabled entries from getChunks() by default instead (ebd7346).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants