show custom element sources in CKE link to {type} #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
deleted the
bugfix/139-linkoptions-custom-element-sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show custom element sources in the link to the entry/category/asset modal.
For custom sources, we don’t have a way of knowing if the elements in that source have URLs or not (so essentially if they can be linked to or not), but the
'criteria' => ['uri' => ':notempty:'],takes care of hiding any elements that don’t have a link. So technically, there’s a chance that custom element sources will show in the modal’s sidebar, but there will be no elements to choose from in them.If approved, I’ll create a PR for Commerce, too.
Related issues
#139