Skip to content

Commit

Permalink
Merge pull request #171 from craftcms/bugfix/168-renamed-list-plugin-…
Browse files Browse the repository at this point in the history
…for-cke-v41

list plugins were renamed in v41
  • Loading branch information
brandonkelly authored Feb 21, 2024
2 parents a15a0d8 + d0d6b90 commit ef89d82
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Added support for creating anchor links. ([#169](https://github.com/craftcms/ckeditor/discussions/169))
- Improved accessibility for screen readers. ([#74](https://github.com/craftcms/ckeditor/issues/74), [#166](https://github.com/craftcms/ckeditor/pull/166))
- Fixed a bug where resized images weren’t getting updated `width` and `height` attributes. ([#165](https://github.com/craftcms/ckeditor/pull/165))
- Fixed JavaScript warnings. ([#168](https://github.com/craftcms/ckeditor/issues/168), [#171](https://github.com/craftcms/ckeditor/pull/171))

## 3.7.3 - 2024-02-08

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/dist/ckeditor5-craftcms.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map

Large diffs are not rendered by default.

22 changes: 12 additions & 10 deletions src/web/assets/ckeditor/src/ckeditor5-craftcms.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,7 @@ import {HorizontalLine} from '@ckeditor/ckeditor5-horizontal-line';
import {HtmlEmbed} from '@ckeditor/ckeditor5-html-embed';
import {Indent, IndentBlock} from '@ckeditor/ckeditor5-indent';
import {LinkEditing, AutoLink, LinkImage} from '@ckeditor/ckeditor5-link';
import {
DocumentList,
DocumentListProperties,
TodoDocumentList,
} from '@ckeditor/ckeditor5-list';
import {List, ListProperties, TodoList} from '@ckeditor/ckeditor5-list';
import {MediaEmbed, MediaEmbedToolbar} from '@ckeditor/ckeditor5-media-embed';
import {PageBreak} from '@ckeditor/ckeditor5-page-break';
import {PasteFromOffice} from '@ckeditor/ckeditor5-paste-from-office';
Expand Down Expand Up @@ -76,8 +72,8 @@ const allPlugins = [
Bold,
Code,
CodeBlock,
DocumentList,
DocumentListProperties,
List,
ListProperties,
Essentials,
FindAndReplace,
Font,
Expand Down Expand Up @@ -112,7 +108,7 @@ const allPlugins = [
TableToolbar,
TableUI,
TextPartLanguage,
TodoDocumentList,
TodoList,
Underline,
WordCount,
CraftImageInsertUI,
Expand Down Expand Up @@ -197,7 +193,7 @@ const pluginButtonMap = [
{plugins: ['Code'], buttons: ['code']},
{plugins: ['CodeBlock'], buttons: ['codeBlock']},
{
plugins: ['DocumentList', 'DocumentListProperties'],
plugins: ['List', 'ListProperties'],
buttons: ['bulletedList', 'numberedList'],
},
{
Expand Down Expand Up @@ -236,7 +232,7 @@ const pluginButtonMap = [
buttons: ['insertTable'],
},
{plugins: ['TextPartLanguage'], buttons: ['textPartLanguage']},
{plugins: ['TodoDocumentList'], buttons: ['todoList']},
{plugins: ['TodoList'], buttons: ['todoList']},
{plugins: ['Underline'], buttons: ['underline']},
];

Expand Down Expand Up @@ -395,6 +391,12 @@ export const create = async function (element, config) {
removePlugins.push('ImageTransform');
}

// remove MediaEmbedToolbar for now
// see: https://github.com/ckeditor/ckeditor5-react/issues/267
// and: https://github.com/ckeditor/ckeditor5/issues/9824
// for more info
removePlugins.push('MediaEmbedToolbar');

if (removePlugins.length) {
plugins = plugins.filter((p) => !removePlugins.includes(p.pluginName));
}
Expand Down

0 comments on commit ef89d82

Please sign in to comment.