Only check $oldEntryIds / $newEntryIds once

craftcms · Mar 7, 2024 · 32f4f00 · 32f4f00
1 parent 46725fb
commit 32f4f00
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Field.php b/src/Field.php
@@ -273,14 +273,18 @@ private static function adjustFieldValues(
         array $newEntryIds,
         bool $propagate,
     ): void {
+        if (empty($oldEntryIds) || $oldEntryIds === $newEntryIds) {
+            return;
+        }
+
         $resave = false;
 
         foreach (self::fieldInstances($owner, $field) as $fieldInstance) {
             /** @var HtmlFieldData|null $oldValue */
             $oldValue = $owner->getFieldValue($fieldInstance->handle);
             $oldValue = $oldValue?->getRawContent();
 
-            if (!$oldValue || empty($oldEntryIds) || $oldEntryIds === $newEntryIds) {
+            if (!$oldValue) {
                 continue;
             }