Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add licenses #33

Merged
merged 2 commits into from
Oct 2, 2023
Merged

chore: add licenses #33

merged 2 commits into from
Oct 2, 2023

Conversation

amr-crabnebula
Copy link
Collaborator

No description provided.

@amr-crabnebula
Copy link
Collaborator Author

@denjell-crabnebula can you please review this?

I can't request review from @denjell-crabnebula directly and I don't know why

denjell-crabnebula
denjell-crabnebula approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@denjell-crabnebula denjell-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is uncontroversial. I think when this is merged we should also change the visibility to public.

@amr-crabnebula amr-crabnebula merged commit 03eb05e into main Oct 2, 2023
8 of 9 checks passed
@amr-crabnebula amr-crabnebula deleted the chore/licensing branch October 2, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denjell-crabnebula denjell-crabnebula denjell-crabnebula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amr-crabnebula @denjell-crabnebula