Improve Support for ValueSet Versions #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this PR,
cql-exec-vsac
supported looking up cached value sets by specific versions -- but it completely ignored version when downloading value sets (it always downloaded the latest). Now, if a value set version is specifically requested, it will download that specific version (if that version is not already in the cache).The unit tests show this working, but if you want to test it IRL, here is one way you could test it:
yarn install
and then runningyarn pack
. This will create a file namedcql-exec-vsac-v1.1.1.tgz
.src/cql/r4/Factors_to_Consider_in_Managing_Chronic_Pain_FHIRv400.json
src/cql/valueset-db.json
2.16.840.1.113762.1.4.1032.109
and note that it contains an empty set of codes:valueset-db.json
file again and search for2.16.840.1.113762.1.4.1032.109
again. If this is working, you'll see that it now contains a small number of codes: