Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning and NewRefreshIg Merge #526

Merged
merged 14 commits into from
May 3, 2024
Merged

Conversation

ddieppois
Copy link
Contributor

Description

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@ddieppois ddieppois self-assigned this Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 20.27%. Comparing base (1f3a5c8) to head (8004ec1).

Files Patch % Lines
.../org/opencds/cqf/tooling/operation/ig/Refresh.java 0.00% 6 Missing ⚠️
...encds/cqf/tooling/operation/ig/LibraryRefresh.java 0.00% 2 Missing ⚠️
...qf/tooling/operation/ig/NewRefreshIGOperation.java 0.00% 1 Missing ⚠️
...processor/argument/RefreshIGArgumentProcessor.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #526      +/-   ##
============================================
+ Coverage     20.25%   20.27%   +0.01%     
- Complexity     1521     1522       +1     
============================================
  Files           296      296              
  Lines         25199    25214      +15     
  Branches       3979     3980       +1     
============================================
+ Hits           5104     5112       +8     
- Misses        19248    19255       +7     
  Partials        847      847              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddieppois ddieppois marked this pull request as ready for review April 26, 2024 19:52
Copy link
Collaborator

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some tests to validate that the operation works.

@ddieppois ddieppois requested a review from JPercival April 29, 2024 21:36
@JPercival JPercival merged commit 2ca0172 into master May 3, 2024
4 checks passed
@JPercival JPercival deleted the versioning-NewRefreshIg-final branch May 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants