Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows to build matrix #495

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Add Windows to build matrix #495

merged 3 commits into from
Nov 30, 2023

Conversation

JPercival
Copy link
Collaborator

Description

Adds a Windows build to the matrix so that we can validate the tests run on Windows.

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@JPercival
Copy link
Collaborator Author

I expect some failures here, this is just setting up a branch to work from.

@JPercival JPercival marked this pull request as ready for review November 30, 2023 01:29
@JPercival JPercival merged commit 3b42f54 into master Nov 30, 2023
2 checks passed
@JPercival JPercival deleted the windows-fixes branch November 30, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant