Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tooling into CLI and class library #395

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

JPercival
Copy link
Collaborator

@JPercival JPercival commented Sep 14, 2022

Description
Splits the cqf-tooling project into a core class library project and a CLI project. This allows the users of the core library to select the platform-appropriate Jaxb/Jackson runtime components. This is just a first pass. I noticed while doing this work that there are two Jaxb implementations on the classpath, as well as two test frameworks. Some further work is needed to fully disentangle all the dependencies.

I also noticed some test content was duplicated. This was removed.

There is an additional refreshIG test that has been enabled, so the test coverage for this PR is actually higher than it was previously.

There's a breaking change, which is that the executable jar (or "fat jar") is now called "tooling-cli".

  • Github Issue: N/A
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

Copy link
Contributor

@c-schuler c-schuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds and tests pass locally

@JPercival JPercival merged commit c43ee6e into master Sep 15, 2022
@JPercival JPercival deleted the feature-split-cli branch September 15, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants