Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature acceleratorkit refactor #253

Merged
merged 48 commits into from
Aug 13, 2021
Merged

Feature acceleratorkit refactor #253

merged 48 commits into from
Aug 13, 2021

Conversation

sliver007
Copy link
Collaborator

Description

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

sliver007 and others added 30 commits March 1, 2021 17:33
@sliver007
Refactor to bind primary code to valueset rather than fixed code
a2ac2aa
@sliver007
Correctly adding and binding choices element
0e2ff01
@sliver007
Updated to respect customValueSetName for choices
7c4efb1
@sliver007
Fixed bug in ActivityId compare
170bb19
@sliver007
Removed commented coded that had been refactored away.
b1989ae
@sliver007
Fixed elementMap ordering bug;
cc6c397
@sliver007
Refactored the ensure element and bind terminology methods, fixed mul…
ac4fb64 
…tiple bugs
@sliver007
Update to ensure full path to modified element is specified
1840f4f
@sliver007
Modified DataElement calculation to allow for null input; added start…
3c62d02 
… of where clause gen for other profiles.
@sliver007
Fix a bug in the Observation case with both Primary code path element…
2155e93 
… and target element being bound to primary codes valueset.
@sliver007
Refactored getExistingElement pattern into method
667269a
Update readme.md
b81afc8
@sliver007
FIxed bug with choices valuset generation
a654ccd
@sliver007
Where clause generation for MedicationRequest profile
703fe63
@sliver007
Where clause for Procedure profile
0edae24
@sliver007
Updated isRequired calculation to include "R" as true; Fixed element …
6e5e81e 
…binding so that only bindable types are bound
@sliver007
Null protection in isBindable method
d84a369
@sliver007
FIx to not generate valueset for non-bindable elements
86b27b2
@sliver007
Added "Extension needed" column
81bba28
@sliver007
Only bind VS to bindable types; set whoCodeSystem url; No longer set …
c309d48 
…element name to type-specific name for choice type elements
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
4b95e4a
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
4e67d60
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
a7465f9
@sliver007
Multiple AcceleratorKit and DecisionTable processor updates
162c304
@sliver007
check for existing element when ensuring full path; replace eM dash; …
72466db 
…anc-specific profile where clauses
@sliver007
Use comments columns for code display;
c531ecb
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
d26fb77
@sliver007
added return clause in Expression generation
53454b1
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
71e1509
@sliver007
Merge branch 'master' into feature_acceleratorkit_refactor
d51a752
sliver007 added 11 commits May 26, 2021 13:28
@sliver007 sliver007 requested a review from brynrhodes June 28, 2021 17:38
brynrhodes
brynrhodes approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds locally, tests pass

@brynrhodes brynrhodes merged commit 4578b3b into master Aug 13, 2021
@brynrhodes brynrhodes deleted the feature_acceleratorkit_refactor branch August 13, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynrhodes brynrhodes brynrhodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sliver007 @brynrhodes @ZackAustin