Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviving dstu3 support #197

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Reviving dstu3 support #197

merged 1 commit into from
Feb 17, 2021

Conversation

JPercival
Copy link
Collaborator

Description
This PR fixes a few issues discovered while trying to build a dstu3 IG

  • Github Issue: N/A
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built without error and passed tests.
Code reviewed and it looks good.
Approved.

@bryantaustin13 bryantaustin13 merged commit 9aede30 into master Feb 17, 2021
@bryantaustin13 bryantaustin13 deleted the feature-revive-dstu3 branch February 17, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants