Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the data roller in 2.4.0 with prefetch items duplicates the entire resource #438

Closed
alackerbauer opened this issue May 3, 2023 · 2 comments
Closed

Running the data roller in 2.4.0 with prefetch items duplicates the entire resource #438

alackerbauer opened this issue May 3, 2023 · 2 comments
Assignees
@alackerbauer
Labels
bug Something isn't working

Comments

@alackerbauer
Copy link
Contributor

alackerbauer commented May 3, 2023 •
edited
Loading

Describe the bug
When refreshing the test data (including data roller), the updated dates only appear in a newly inserted nested resource element within the original resource.

To Reproduce
Steps to reproduce the behavior:

  1. check out the opioid IG branch https://github.com/cqframework/opioid-cds-r4/tree/258-remove-response-resource-v2016
  2. open file input/pagecontent/requests/OpioidCDSREC01/request-example-rec-01-in-outpatient-opioid.json as one example
  3. copy the content of the file somewhere to later compare with the incorrectly modified file
  4. run sh _updateCQFTooling.sh to make sure you are executing the following steps on the defined tooling version 2.4.0
  5. run sh _updateTestData.sh to execute the data roller functionality
  6. re-open modified file input/pagecontent/requests/OpioidCDSREC01/request-example-rec-01-in-outpatient-opioid.json
  7. compare the content with the initial content of step 2
  8. find that the dates in the relevant elements haven't changed, but a new nested duplicated resource has been inserted, with changed dates

Expected behavior
The data roller updates dates directly in the relevant elements of the resource, and the nested resource duplication does not happen.

Additional context
Found as part of the Opioid IG project, mentioned as "duplication bug" here and here

Screenshot 2023-05-03 at 09 07 11
@alackerbauer alackerbauer added the bug Something isn't working label May 3, 2023
@alackerbauer alackerbauer self-assigned this May 3, 2023
@alackerbauer alackerbauer changed the title New Prefetch format duplicated entire resource Running the data roller in 2.4.0 duplicates the entire resource May 3, 2023
@alackerbauer alackerbauer changed the title Running the data roller in 2.4.0 duplicates the entire resource Running the data roller in 2.4.0 with prefetch items duplicates the entire resource May 3, 2023
alackerbauer pushed a commit that referenced this issue May 3, 2023
#438 fix changed cardinality of category that causes warinings (stu3 …
4f700b8 
…vs r4)
@alackerbauer
Copy link
Contributor Author

pull request: #439

c-schuler added a commit that referenced this issue Jun 6, 2023
@alackerbauer @c-schuler
#438 structure of prefetch - resource (#439)
331a0e9 
* #438 fix changed cardinality of category that causes warinings (stu3 vs r4)

* Cleaned up code - added pretty print default for IOUtils - added test case without prefetch and missing item in prefetch (now adding missing items with null values when not present)

---------

Co-authored-by: Anna <[email protected]>
Co-authored-by: c-schuler <[email protected]>
@Chris0296
Copy link
Contributor

Completed as per discussion with @alackerbauer. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alackerbauer alackerbauer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alackerbauer @Chris0296