Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#449: Implemented support for namespaces in the translator. This requ… #498

Merged
merged 1 commit into from
Apr 14, 2020
Merged

#449: Implemented support for namespaces in the translator. This requ… #498

merged 1 commit into from
Apr 14, 2020

Conversation

brynrhodes
Copy link
Member

…ired one change to the cqlannotations.xsd, a non-normative aspect of the specification, to ensure that errors encountered in libraries referenced in other namespaces could be unambiguously identified.

@brynrhodes
#449: Implemented support for namespaces in the translator. This requ…
e5a5d7b 
…ired one change to the cqlannotations.xsd, a non-normative aspect of the specification, to ensure that errors encountered in libraries referenced in other namespaces could be unambiguously identified.
@brynrhodes brynrhodes requested review from cmoesel and JPercival April 5, 2020 20:21
JPercival
JPercival approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally and passes tests locally.

Not a blocker from merging, but it'd be nice to see some tests that ensure namespaces and versions play together nicely since they both are part of Library resolution.

@brynrhodes brynrhodes requested a review from c-schuler April 10, 2020 17:55
c-schuler
c-schuler approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@c-schuler c-schuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Builds and tests pass locally

@brynrhodes brynrhodes merged commit 7ce9d48 into master Apr 14, 2020
@brynrhodes brynrhodes deleted the fix-449-implement-namespace-support branch April 14, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPercival JPercival JPercival approved these changes

@c-schuler c-schuler c-schuler approved these changes

@cmoesel cmoesel Awaiting requested review from cmoesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brynrhodes @JPercival @c-schuler