You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using the cql-to-elm library and have observed that when combining styles of comments the newline after the last comment is lost, causing issues with downstream consumers of the generated ELM.
CQL:
library ObsTestN1 version '0.0.000'
using FHIR version '4.0.1'
include FHIRHelpers version '4.1.000' called FHIRHelpers
parameter "Measurement Period" Interval<DateTime>
context Patient
/* Multi-line works fine */
// Single-line comment does not work
define "boolIpp":
exists ["Encounter"] E where E.period.start during "Measurement Period"
Here are some screenshots of the issue as observed after passing the ELM to fqm-execution:
The issue is not observed when comment styles are not mixed:
The issue is also not observed if a multi-line comment comes after the single-line comments:
These screenshots were all coming from fqm-execution library output, but we can see here the actual cql-to-elm output where the newline character is being lost:
versus what appears when we only use single-line comment style:
* #1156: Added test cases for CMS143 and CMS149 to validate data requirements output
* #1147: Fixed invalid let ref during data requirements inference
* #1146: Added test for MedicationRequest to ensure expected ELM output
* #1109: Fixed newlines being stripped incorrectly in mixed single- and multi-line comments
* #1156: Added test cases for CMS143 and CMS149 to validate data requirements output
* #1147: Fixed invalid let ref during data requirements inference
* #1146: Added test for MedicationRequest to ensure expected ELM output
* #1109: Fixed newlines being stripped incorrectly in mixed single- and multi-line comments
We are using the cql-to-elm library and have observed that when combining styles of comments the newline after the last comment is lost, causing issues with downstream consumers of the generated ELM.
CQL:
Here are some screenshots of the issue as observed after passing the ELM to fqm-execution:
The issue is not observed when comment styles are not mixed:
The issue is also not observed if a multi-line comment comes after the single-line comments:
These screenshots were all coming from fqm-execution library output, but we can see here the actual cql-to-elm output where the newline character is being lost:
versus what appears when we only use single-line comment style:
Adding @JSRankins here as well
The text was updated successfully, but these errors were encountered: