Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing JAXB dependencies from the engine. #73

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Removing JAXB dependencies from the engine. #73

merged 2 commits into from
Dec 24, 2021

Conversation

vitorpamplona
Copy link
Contributor

  • Removed JAXB dependencies from the engine.
  • Corrected an evaluator (ProperlyIncludes) class name to match the generated class.
  • Adjusted tests to avoid XML loads.

@vitorpamplona
Copy link
Contributor Author

vitorpamplona commented Dec 16, 2021 •
edited
Loading

Folks, since we have already merged the Engine's removal of the JAXB, we need this PR approved in order to work with the $apply/PlanDefinition one. Otherwise, we can't compile the evaluator without rolling back the CQL Engine itself.

brynrhodes
brynrhodes previously requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing an error in the build that it cannot construct a LibraryMapper. Seems to be related to the change in the names from Properly to Proper?

@JPercival
Copy link
Contributor

Don’t merge this one yet. I need to get 1.3.1 out the door.

@JPercival JPercival dismissed brynrhodes’s stale review December 24, 2021 20:53

I went ahead and resolved the issues on mater

@JPercival JPercival merged commit d7435e9 into cqframework:master Dec 24, 2021
@vitorpamplona vitorpamplona mentioned this pull request Sep 19, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPercival JPercival JPercival approved these changes

@brynrhodes brynrhodes brynrhodes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorpamplona @JPercival @brynrhodes